Skip to content

lib: use bracket notation instead of startsWith/endsWith for single char - #61500

Open
kimtaejin3 wants to merge 1 commit into
nodejs:mainfrom
kimtaejin3:lib/use-bracket-notation-for-single-char
Open

lib: use bracket notation instead of startsWith/endsWith for single char#61500
kimtaejin3 wants to merge 1 commit into
nodejs:mainfrom
kimtaejin3:lib/use-bracket-notation-for-single-char

Conversation

@kimtaejin3

@kimtaejin3 kimtaejin3 commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

This PR avoids potential prototype pollution and improves performance by replacing method calls with
direct property access.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jan 24, 2026
@codecov

codecov Bot commented Jan 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (9472421) to head (5355e9f).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61500      +/-   ##
==========================================
- Coverage   90.12%   90.12%   -0.01%     
==========================================
  Files         752      752              
  Lines      252312   252319       +7     
  Branches    47432    47436       +4     
==========================================
+ Hits       227404   227406       +2     
  Misses      16217    16217              
- Partials     8691     8696       +5
Files with missing lines Coverage Δ
lib/internal/socketaddress.js 98.98% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kimtaejin3 kimtaejin3 changed the title lib: use bracket notation instead of startsWith/endsWith for single char lib: use bracket notation instead of startsWith/endsWith for single char Jan 24, 2026
@kimtaejin3

kimtaejin3 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

@anonrig Could you please check the progress of this PR? It looks like it might be stuck after approval.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale label Jul 28, 2026
@ljharb ljharb added never-stale Mark issue so that it is never considered stale and removed stale labels Jul 29, 2026
@trivikr
trivikr force-pushed the lib/use-bracket-notation-for-single-char branch from d6f31dc to fb03a1e Compare August 21, 2026 00:05
@trivikr trivikr added request-ci Add this label to start a Jenkins CI on a PR. and removed never-stale Mark issue so that it is never considered stale labels Aug 21, 2026
@trivikr trivikr added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@trivikr

trivikr commented Aug 21, 2026

Copy link
Copy Markdown
Member

@kimtaejin3 Can you please sign the first commit and force push?

It's required as per updated instructions

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin

@trivikr trivikr removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 21, 2026
@kimtaejin3
lib: use bracket notation instead of startsWith/endsWith for single char
5355e9f 
Signed-off-by: Taejin Kim <rlaxowls1316@naver.com>
@kimtaejin3
kimtaejin3 force-pushed the lib/use-bracket-notation-for-single-char branch from fb03a1e to 5355e9f Compare August 21, 2026 06:44
@trivikr trivikr added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76182/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kimtaejin3 @trivikr @nodejs-github-bot @ljharb @lpinca @anonrig @cjihrig @bjohansebas